Implementation Edit to Bogo Sort in Javascript #291
Conversation
- Added main() - bogoSort() now returns the sorted array
Gathros
added
the
Implementation Edit
| @@ -12,6 +12,7 @@ function bogoSort(arr) { | |||
| while (!isSorted(arr)) { | |||
| shuffle(arr); | |||
| } | |||
| return arr; | |||
There was a problem hiding this comment.
The function doesn't have to return the array, because it's passed by reference anyway.
|
|
||
| function main() { | ||
| var testArray = [4,5,123,24,34,-5]; | ||
| print(bogoSort(testArray)); |
There was a problem hiding this comment.
print does not exist in JavaScript. And because you don't need return arr above, you'd have to output it like this:
bogoSort(testArray);
console.log(testArray);
| @@ -22,3 +23,10 @@ function shuffle(arr) { | |||
| arr[r] = tmp; | |||
| } | |||
| } | |||
|
|
|||
| function main() { | |||
| var testArray = [4,5,123,24,34,-5]; | |||
There was a problem hiding this comment.
Similarly to the other PR: JS files should be indented with 2 spaces and use const for non-chaning variables (and let for mutable ones). var is pretty much legacy at this point. Also, there should be spaces after the commas in the array initialization ([1, 2, 3] instead of [1,2,3]).
|
Sorry for all the mistakes in my Javascript PRs. Clearly I'm not super comfortable with Javascript. Thanks for helping me out with my PRs and I think I've fixed both Javascript PRs. |
| @@ -25,8 +24,9 @@ function shuffle(arr) { | |||
| } | |||
|
|
|||
| function main() { | |||
| var testArray = [4,5,123,24,34,-5]; | |||
| print(bogoSort(testArray)); | |||
| let testArray = [4, 5, 123, 24, 34, -5]; | |||
There was a problem hiding this comment.
This doesn't change, it should be const. Same in the other PR
There was a problem hiding this comment.
Oops, sorry about that. I made a commit to correct the code.
There was a problem hiding this comment.
Why does this not change? It's being sorted later.
|
@Butt4cak3 @Gustorn How is the state of this PR? |
|
Looks fine with changes requested |
| @@ -22,3 +22,11 @@ function shuffle(arr) { | |||
| arr[r] = tmp; | |||
| } | |||
| } | |||
|
|
|||
| function main() { | |||
| const testArray = [4, 5, 123, 24, 34, -5]; | |||
There was a problem hiding this comment.
I don't know JS too well, but if you declare testArray and const can you actually modify it?
There was a problem hiding this comment.
yes, you can not reassign this. but you can add/remove/reorder elements in array like this.
jiegillet
dismissed
Butt4cak3’s stale review
Changes were made as requested, Butt4cak3 was away
Added main() to code so that it can be run as is